Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only trigger deploy on cron task, and tests on push / pull requests #16317

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Nov 7, 2019

Questions Answers
Branch? develop
Description? Deploy should be trigger alone on cron task. And tests should be triggered on push / pull request only. Remove phpHigh which failing all the time, this test is useless an consume memory for nothing.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16280
How to test? Travis must be green. You should be able to trigger a cron task on my branch :)
FYI an example of CRON: https://travis-ci.org/PierreRambaud/PrestaShop/builds/609289135?utm_medium=notification&utm_source=email (failing because I wanted it)

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 7, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 7, 2019
@atomiix
atomiix approved these changes Nov 8, 2019
@@ -58,9 +64,6 @@ matrix:
local-dir: "/tmp/ps-release"
on:
all_branches: true
allow_failures:
- php: 7.2
env: EXTRA_DEPS=phpHigh PRESTASHOP_TEST_TYPE=unit

This comment has been minimized.

Copy link
@eternoendless

eternoendless Nov 8, 2019

Member

Why are you removing these tests?

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Nov 12, 2019

Author Contributor

Because it forces to update all our dependencies without considering the platform, the php compatibility or the dependency compatibility. For example, it currently update Pelago\Emogrifier\HtmlProcessor and break everything, and if you update the code for this dependency, another one's broken again, etc. https://travis-ci.com/PrestaShop/PrestaShop/jobs/254513713#L651

It should have been useful if the update was only for Twig2, not all our dependencies.
Since we never check this one, it's consider as a useless travis job

This comment has been minimized.

Copy link
@eternoendless

eternoendless Nov 13, 2019

Member

okay then

@PierreRambaud PierreRambaud merged commit 2ae16b9 into PrestaShop:develop Nov 13, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.