Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customer group price display preference for display order in BO #16319

Conversation

@matks
Copy link
Contributor

matks commented Nov 7, 2019

Questions Answers
Branch? develop
Description? Use customer group price display preference for display order in BO
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14732
How to test? See below. Dont forget to rebuild assets.

How to test?

Expected behavior:
In both migrated pages "Listing of orders" and "Edit/view an order",

  • if the main customer group for the customer of the order has "display tax included" setting, then display the order as "tax included"
  • if the main customer group for the customer of the order has "display tax excluded" setting, then display the order as "tax excluded"

Additionally, for Order Preview on listing of orders, if the display method is "tax included" then the "tax" column is not displayed.


This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 7, 2019
@matks matks force-pushed the matks:handle-customer-group-tax-settings-for-order-preview branch from 3c3d108 to cacd6bb Nov 7, 2019
@matks matks force-pushed the matks:handle-customer-group-tax-settings-for-order-preview branch from cacd6bb to c7c3208 Nov 7, 2019
@matks matks added the High label Nov 7, 2019
@sarahdib sarahdib self-assigned this Nov 8, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 8, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Nov 8, 2019
@sarahdib sarahdib added QA ✔️ and removed QA ✔️ labels Nov 8, 2019
@PierreRambaud PierreRambaud merged commit 3c530ad into PrestaShop:develop Nov 8, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 8, 2019

Thanks @matks

@matks matks deleted the matks:handle-customer-group-tax-settings-for-order-preview branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.