Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update id_order_state at the right place #16335

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@atomiix
Copy link
Contributor

atomiix commented Nov 8, 2019

Questions Answers
Branch? 1.7.6.x
Description? In case where $cart_total_paid is different from $amount_paid, the $id_order_state wasn't updated in the right context
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15834
How to test? See #15834

This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 8, 2019
@atomiix atomiix changed the title fix id_order_state not updated at the right place update id_order_state at the right place Nov 8, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Nov 8, 2019
@sarahdib sarahdib self-assigned this Nov 12, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Nov 12, 2019
@PierreRambaud PierreRambaud merged commit 1147321 into PrestaShop:1.7.6.x Nov 12, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 12, 2019

Thanks @atomiix

@atomiix atomiix changed the title update id_order_state at the right place Update id_order_state at the right place Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.