Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig\HookExtension: Bugfix ob level in renderHooksArray #16360

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@jnvsor
Copy link
Contributor

jnvsor commented Nov 11, 2019

Questions Answers
Branch? develop
Description? HookExtension::renderHooksArray increases ob level without closing it.

This can cause a WSOD on twig pages that make use of it in certain circumstances, but the WSOD isn't easily reproducible.

(The WSOD occurred after an autoupgrade from 1.7.5.1 to 1.7.6.1 with the displayAdminProductsExtra call in product.html.twig on PHP CGI, but couldn't be reproduced in a clean test under identical circumstances)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Dump ob_get_level() before calling Request::send()

This change is Reviewable

@jnvsor jnvsor requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 11, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Nov 11, 2019

Hello @jnvsor!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 12, 2019

Woot, nice catch!
This pull request is technical, one more approve and we can merge it!

Copy link
Contributor

Progi1984 left a comment

Nice catch ;)

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Nov 12, 2019
@PierreRambaud PierreRambaud merged commit 7ee4a15 into PrestaShop:develop Nov 12, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 12, 2019

Thanks @jnvsor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.