Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the change the quantity of a free product in an order in the BO #16392

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Nov 13, 2019

Questions Answers
Branch? develop
Description? When you create an order with the price of the product = 0 and you try to change the quantity, an error message appears "Error: the price of the product must be set".
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9830 & http://forge.prestashop.com/browse/PSCSX-8761
How to test? * BO > create a new product (P) with price = 0
* FO > order product P
* BO > the order details page, try to change the quantity of the product and check if the error message "Error: The price of the product must be set" is not displayed

Initial PR : #8712 by @Azouz-Jribi


This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 13, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 13, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Nov 13, 2019
@PierreRambaud PierreRambaud merged commit 6c85eff into PrestaShop:develop Nov 14, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 14, 2019

Thanks @Progi1984

@Progi1984 Progi1984 deleted the Progi1984:issue9830 branch Nov 14, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Nov 14, 2019

Thanks @Azouz-Jribi for the initial PR. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.