Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default attribute when no one are passed in front page #16423

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Nov 15, 2019

Questions Answers
Branch? 1.7.6.x
Description? Check for default attribute when no one are passed in the URL
Type? bug fix
Category? FO
BC breaks? no
Deprecations? /no
Fixed ticket? Fixes #16417
How to test? Follow ticket instruction.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 15, 2019
@PierreRambaud PierreRambaud changed the title Use default attribute when no one are passed Use default attribute when no one are passed in front page Nov 15, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Nov 15, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/16417 branch 2 times, most recently from e43d525 to af7dd72 Nov 15, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/16417 branch from e01584a to 03aaf33 Nov 15, 2019
Copy link
Contributor

jolelievre left a comment

@Progi1984 Progi1984 merged commit 7311e44 into PrestaShop:1.7.6.x Nov 15, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 added this to the 1.7.6.2 milestone Nov 15, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Nov 15, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 15, 2019

👏

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/16417 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.