Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module alias in webpack configuration for the new-theme #16432

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Nov 15, 2019

Questions Answers
Branch? develop
Description? We are a little bit bored about the import '../../../../../../' in javascript files. So we add a webpack aliases for @js, @app, @pages, @components, @scss, @node_modules.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? partial fix #13943
How to test? Nothing should change in the BO.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 15, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 15, 2019

Waiting for a 2nd review

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Nov 25, 2019

Hi @PierreRambaud ! Could you resolve the conflict on this PR ?

And, if possible, could you give us a more detailed way to test ? (or explained what this PR change ?)

Thanks !

@PierreRambaud PierreRambaud dismissed stale reviews from Progi1984 and matks via 1a409b7 Nov 25, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:module-alias branch from 4c9587b to 1a409b7 Nov 25, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Nov 25, 2019

@Robin-Fischer-PS Since we change many things in the javascript, you need to open all pages and make sure there is no error in the javascript console. :)

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:module-alias branch from 1a409b7 to 93b188f Dec 11, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Dec 11, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 11, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 11, 2019

Hi @PierreRambaud ! I tested majority of the BO page (but not all actions, of course...), did not see any new errors.

So it's QA ✔️ !

@Progi1984 Progi1984 merged commit 9751349 into PrestaShop:develop Dec 11, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud PierreRambaud deleted the PierreRambaud:module-alias branch Dec 11, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 12, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.