Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing contact layout not working at all #16520

Merged
merged 4 commits into from Jan 10, 2020
Merged

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Nov 25, 2019

Questions Answers
Branch? develop
Description? contact layout other than with left columns were not working at all, It may break theme users if these templates are in their child theme, I need an advice about this.
Type? bug fix
Category? FO
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #10140
How to test? Just change the contact page layout in theme configuration and watch if every layouts are working

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 25, 2019
@NeOMakinG NeOMakinG added the FO label Nov 25, 2019
Copy link
Contributor

matthieu-rolland left a comment

Two minor changes requested, until you get some feedback for the problem you mentioned in the PR description...

themes/classic/templates/contact.tpl Outdated Show resolved Hide resolved
@NeOMakinG

This comment has been minimized.

Copy link
Contributor Author

NeOMakinG commented Nov 28, 2019

For the reviewer : I don't know if the best solution is to do this, I think we could have a var from the backend which told the template in which type of layout he is so he can choose if he wants to populate a hook in case of a specific layout

@NeOMakinG

This comment has been minimized.

Copy link
Contributor Author

NeOMakinG commented Dec 12, 2019

$layout returns the layout selected, I refactored the PR to use it, it's way cleaner and less breaker I think :)

@NeOMakinG NeOMakinG requested a review from jolelievre Dec 12, 2019
@NeOMakinG NeOMakinG dismissed matthieu-rolland’s stale review Dec 20, 2019

Idk what it has a change requested while everything changed

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jan 10, 2020
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jan 10, 2020
@Progi1984 Progi1984 merged commit f890f1b into PrestaShop:develop Jan 10, 2020
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable 1 file, 8 discussions left (eternoendless, jolelievre, NeOMakinG)
Details
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 10, 2020

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.