Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching select of ps_brandlist to a bootstrap dropdown #16524

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Nov 25, 2019

Questions Answers
Branch? develop
Description? The select of brand module on category page is ugly, let's use a bootstrap dropdown we already use on this page. See also : PrestaShop/ps_brandlist#6
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9670
How to test? Install the ps_brandlist module, then change the configuration to dropdown instead of plain text

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 25, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Dec 2, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Dec 2, 2019
@sarahdib sarahdib self-assigned this Dec 2, 2019
@NeOMakinG NeOMakinG force-pushed the NeOMakinG:issue9670 branch from fccd430 to ce14efa Dec 2, 2019
Copy link
Contributor

Progi1984 left a comment

Rebase ☑️

@Progi1984 Progi1984 merged commit e8ff1d7 into PrestaShop:develop Dec 2, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Dec 2, 2019

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.