Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check memory_limit during installation #16527

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Nov 25, 2019

Questions Answers
Branch? develop
Description? PHP's config memory_limit must be checked during installation process
Type? improvement
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16507
How to test? Decrease your memory_limit to 128M to see this message
image

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 25, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 25, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm !

@matthieu-rolland matthieu-rolland dismissed their stale review Nov 26, 2019

Waiting for prettyCI to be valid

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/16507 branch from ddac9b8 to fb1bfb0 Nov 27, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm, thanx @PierreRambaud !

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 2, 2019

Hi @PierreRambaud !

There is a way to skip this step : When there is an install cache on the browser, a new install starts at the "Store information" step, so the memory is not verified in this case. I don't know if there is an easy way to prevent users from skipping step "System compatibility" ?

Thanks

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 2, 2019

@Robin-Fischer-PS If all tests are green, this step seems to be skipped, but in fact, no. If you change your memory limit and restart your apache server or your php-fpm, you can restart the installation and you'll see the warning.

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 2, 2019

@PierreRambaud See on this screenrecord, the even if the memory limit is not high enough, I can skip the step (I just go back on step 3 to show the memory is not OK) :

https://drive.google.com/file/d/1LXxvvqrZBsqpyNJAVR4S1J_bbTtICe7B/view?usp=sharing

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 2, 2019

@PierreRambaud See on this screenrecord, the even if the memory limit is not high enough, I can skip the step (I just go back on step 3 to show the memory is not OK) :

https://drive.google.com/file/d/1LXxvvqrZBsqpyNJAVR4S1J_bbTtICe7B/view?usp=sharing

This is a normal behaviour because of sessions 😅

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 2, 2019

Thanks, so it's QA approved :P

@PierreRambaud PierreRambaud merged commit 115770d into PrestaShop:develop Dec 2, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 2, 2019

Thanks me!

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/16507 branch Dec 2, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 2, 2019

Thanks @PierreRambaud :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.