Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing links block style in carrier process #16528

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Nov 25, 2019

Questions Answers
Branch? develop
Description? Link module markup is creating problems on carrier step of the checkout process
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9618
How to test? Create a link block with the link ps_linklist module and attach it to the displayAfterCarrier hook, don't forget to add links to the block, then go to the checkout process like you'd buy something, the links should display properly

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 25, 2019
@prestonBot prestonBot added the Bug label Nov 25, 2019
@NeOMakinG NeOMakinG added the FO label Nov 25, 2019
Copy link
Contributor

matthieu-rolland left a comment

looks good to me 👍

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

matthieu-rolland commented Nov 25, 2019

@NeOMakinG is this meant to go on develop ?

@prestonBot prestonBot added the develop label Nov 25, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 25, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 2, 2019

Hi @NeOMakinG :)

Could you resolve the conflict on the theme.css file ? Thanks !

@NeOMakinG NeOMakinG dismissed stale reviews from PierreRambaud and matthieu-rolland via 1224de5 Dec 2, 2019
@NeOMakinG NeOMakinG force-pushed the NeOMakinG:issue9618 branch from 5e7b539 to 1224de5 Dec 2, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Dec 5, 2019
@sarahdib sarahdib self-assigned this Dec 5, 2019
@PierreRambaud PierreRambaud merged commit 7a3e35c into PrestaShop:develop Dec 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 5, 2019

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.