Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic ButtonBulkAction and javascript to handle open in tabs #16552

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Nov 26, 2019

Questions Answers
Branch? develop
Description? Add generic ButtonBulkAction and javascript to handle open in tabs
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16455
How to test? In order view select some orders and use the bulk action Open in new tabs By default your browser should block and only open one tab Then in the list page you will see an alert advising you to change your browser settings to allow more popup Once it is done you can open as many tabs as you want

This change is Reviewable

@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 26, 2019
@jolelievre jolelievre force-pushed the jolelievre:bulk-open-tabs branch from d124917 to db49b4c Nov 29, 2019
@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Nov 29, 2019

@PierreRambaud @matthieu-rolland I forgot to push it yesterday, but it should be ok now

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 2, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Dec 2, 2019
@jolelievre jolelievre force-pushed the jolelievre:bulk-open-tabs branch from db49b4c to 253a800 Dec 2, 2019
Copy link
Contributor

Progi1984 left a comment

Rebased ☑️

@Progi1984 Progi1984 merged commit 07faf98 into PrestaShop:develop Dec 2, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Dec 2, 2019

Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.