Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product cannot be deleted from cart IF another customization is made and not added to cart yet #16574

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 27, 2019

Questions Answers
Branch? develop
Description? If customization for current product_id and cart_id exists and is not added to cart, it is not possible to remove any instance of this product from cart. The logic checks for amount of other customizations in cart, to check minimum quantity. BUT, somebody forgot to add a condition, so it checks only customizations that are actually in cart and have some quantity. This PR restores the correct function.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #16283
How to test? -

This change is Reviewable

@Hlavtox Hlavtox requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 27, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Nov 27, 2019

Hello @Hlavtox!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Hlavtox Hlavtox changed the title Prevent error when deleting product from cart if orphaned customizations exist Fix product cannot be deleted from cart IF another customization is made and not added to cart yet Dec 19, 2019
@atomiix
atomiix approved these changes Jan 9, 2020
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jan 10, 2020
@sarahdib sarahdib added this to the 1.7.7.0 milestone Jan 10, 2020
@Progi1984 Progi1984 merged commit 4be4b55 into PrestaShop:develop Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 10, 2020

Thanks @Hlavtox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.