Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated "create_function" #16632

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@mvorisek
Copy link
Contributor

mvorisek commented Nov 30, 2019

Questions Answers
Branch? develop
Description? Replace deprecated "create_function"
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? No new feature

This change is Reviewable

@mvorisek mvorisek requested a review from PrestaShop/prestashop-core-developers as a code owner Nov 30, 2019
@mvorisek mvorisek force-pushed the mvorisek:gh_replace_create_func branch from c1019e6 to 9f29ed1 Nov 30, 2019
@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Dec 16, 2019

Any feedback? create_function usage is deprecated since PHP 7.2.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 17, 2019

@mvorisek Thanks. In fact, we already know, but this part of code are used only for tests, and are never executed 😅 We should refactor our test modules to only use what we want (one hook, install, uninstall, reset) and not all the useless code around.

@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Dec 17, 2019

@PierreRambaud Yes, I know, but I was getting warnings from out internal tests so I fixed it. Is this PR welcomed or should I delete the PR?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 17, 2019

Let's approve this. One more review and merge without QA ;)

@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Jan 9, 2020

Can someone approve and merge?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 9, 2020

Sorry, it was a good idea to ping 😉

@matks matks added this to the 1.7.7.0 milestone Jan 9, 2020
@matks matks merged commit 7a17ac6 into PrestaShop:develop Jan 9, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 9, 2020

Thank you @mvorisek

@mvorisek mvorisek deleted the mvorisek:gh_replace_create_func branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.