Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix customer statuses not being able to toggle when optin field is required #16648

Merged
merged 4 commits into from Dec 5, 2019
Merged

Fix customer statuses not being able to toggle when optin field is required #16648

merged 4 commits into from Dec 5, 2019

Conversation

matthieu-rolland
Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Dec 2, 2019 •
edited by eternoendless

Questions Answers
Branch? 1.7.6.x
Description? Make it possible to toggle customer newsletter subscription even when partner offer is set as a required field.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16509
How to test? See below (and also the issue #16509)
  1. Go to BO => Customers => Click on Set required fields for this section
  2. Check the "Partner offers" option
  3. Save
  4. Create a new customer from BO with enabling Partner offers => the customer is successfully saved
  5. In the Customers list page, try to disable this customer or try to enable the Newsletter option
  6. It should work !

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from a team as a code owner December 2, 2019 10:52
@prestonBot prestonBot added the 1.7.6.x Branch label Dec 2, 2019
@matthieu-rolland matthieu-rolland added this to In progress in PrestaShop 1.7.6 via automation Dec 2, 2019
@matthieu-rolland matthieu-rolland moved this from In progress to To be reviewed in PrestaShop 1.7.6 Dec 2, 2019
@PrestaShop PrestaShop deleted a comment from prestonBot Dec 2, 2019
PierreRambaud
PierreRambaud previously approved these changes Dec 2, 2019
View reviewed changes
@PierreRambaud
Copy link
Contributor

PrettyCi needs to be fixed ;)

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Dec 2, 2019
@colinegin colinegin removed the Waiting for QA Status: action required, waiting for test feedback label Dec 4, 2019
@colinegin colinegin removed this from To be reviewed in PrestaShop 1.7.6 Dec 4, 2019
@colinegin colinegin added the Waiting for QA Status: action required, waiting for test feedback label Dec 4, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 4, 2019
@Robin-Fischer-PS
Copy link
Contributor

Hi ! Thanks to the new behavior decided here : #16509 (comment)

This PR is QA approved ✔️

Thanks @matthieu-rolland !

@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Dec 4, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.3 milestone Dec 4, 2019
@PierreRambaud PierreRambaud merged commit e084cba into PrestaShop:1.7.6.x Dec 5, 2019
@PierreRambaud
Copy link
Contributor

Thanks @matthieu-rolland

@Progi1984 Progi1984 mentioned this pull request Dec 19, 2019
Closed
@matks matks mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees

@Robin-Fischer-PS Robin-Fischer-PS

Labels
1.7.6.x Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthieu-rolland @PierreRambaud @Robin-Fischer-PS @prestonBot @colinegin