Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customer statuses not being able to toggle when optin field is required #16648

Merged

Conversation

@matthieu-rolland
Copy link
Contributor

matthieu-rolland commented Dec 2, 2019

Questions Answers
Branch? 1.7.6.x
Description? Make it possible to toggle customer newsletter subscription even when partner offer is set as a required field.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16509
How to test? See below (and also the issue #16509)
  1. Go to BO => Customers => Click on Set required fields for this section
  2. Check the "Partner offers" option
  3. Save
  4. Create a new customer from BO with enabling Partner offers => the customer is successfully saved
  5. In the Customers list page, try to disable this customer or try to enable the Newsletter option
  6. It should work !

This change is Reviewable

@matthieu-rolland matthieu-rolland requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 2, 2019
@prestonBot prestonBot added the 1.7.6.x label Dec 2, 2019
@matthieu-rolland matthieu-rolland added this to In progress in PrestaShop 1.7.6 via automation Dec 2, 2019
@matthieu-rolland matthieu-rolland moved this from In progress to To be reviewed in PrestaShop 1.7.6 Dec 2, 2019
@PrestaShop PrestaShop deleted a comment from prestonBot Dec 2, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 2, 2019

PrettyCi needs to be fixed ;)

@matthieu-rolland matthieu-rolland force-pushed the matthieu-rolland:fix-customer-status-toggle branch from f54a1de to fb35b9a Dec 2, 2019
@colinegin colinegin removed this from To be reviewed in PrestaShop 1.7.6 Dec 4, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 4, 2019
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 4, 2019

Hi ! Thanks to the new behavior decided here : #16509 (comment)

This PR is QA approved ✔️

Thanks @matthieu-rolland !

@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.3 milestone Dec 4, 2019
@PierreRambaud PierreRambaud merged commit e084cba into PrestaShop:1.7.6.x Dec 5, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.