Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP docblocks #16662

Merged
merged 1 commit into from Dec 3, 2019
Merged

Fix PHP docblocks #16662

merged 1 commit into from Dec 3, 2019

Conversation

@mfurga
Copy link
Contributor

mfurga commented Dec 2, 2019

Questions Answers
Branch? develop
Description? Fix PHP docblocks. Change the type of function parameters from bool to int.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Just comments

This change is Reviewable

@mfurga mfurga requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 2, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 2, 2019

Hello @mfurga!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Progi1984 Progi1984 merged commit 74c7a8a into PrestaShop:develop Dec 3, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Dec 3, 2019

No need QA : Only PHPDoc

Thansk @mfurga

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Dec 3, 2019
@mfurga mfurga deleted the mfurga:fix-php-docblocks branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.