Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email theme permission #16696

Merged
merged 5 commits into from Jan 7, 2020
Merged

Conversation

@atomiix
Copy link
Contributor

atomiix commented Dec 5, 2019

Questions Answers
Branch? 1.7.6.x
Description? Add missing AdminMailTheme parent tab rights
Type? bug fix
Category? BO
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #16337
How to test? See below

How to test?

There is two ways to test that PR.

  1. After a fresh install on branch 1.7.6.x
  2. After an upgrade from 1.7.6.2 to 1.7.6.x

Either case, you should be able to change Email Themes permissions in configure > Advanced parameters > Team > Permissions


This change is Reviewable

@atomiix atomiix requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 5, 2019
@atomiix atomiix added Bug fix and removed Bug labels Dec 5, 2019
@atomiix atomiix added this to the 1.7.7.0 milestone Dec 5, 2019
Copy link
Contributor

jolelievre left a comment

Some little adjustments to avoid losing permissions, or tabs
But one more important question: why does it target the 177? It should be a 176 fix for 1763 no?

install-dev/data/xml/tab.xml Show resolved Hide resolved
);

// Move AdminMailTheme's parent from AdminMailThemeParent to AdminParentMailTheme
$toParentTabId = Db::getInstance()->getValue(

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 13, 2019

Contributor

Ok I get it, you move children tabs from the former AdminMailThemeParent to AdminParentMailTheme
But if some modules already used AdminMailThemeParent as their parent tab then it will become messy, so we'd better keep the original ones and just fix the permissions

@atomiix atomiix force-pushed the atomiix:fix-email-theme-permission branch from bd9fec5 to 8c91883 Dec 18, 2019
@atomiix atomiix changed the base branch from develop to 1.7.6.x Dec 18, 2019
@prestonBot prestonBot added the Bug label Dec 18, 2019
@atomiix atomiix added 1.7.6.x and removed develop labels Dec 18, 2019
@atomiix atomiix modified the milestones: 1.7.7.0, 1.7.6.3 Dec 18, 2019
@prestonBot prestonBot added the develop label Dec 18, 2019
@atomiix atomiix closed this Dec 19, 2019
@atomiix atomiix reopened this Dec 19, 2019
@Progi1984 Progi1984 requested review from jolelievre and PierreRambaud Dec 19, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Jan 7, 2020
@Progi1984 Progi1984 merged commit c8dc023 into PrestaShop:1.7.6.x Jan 7, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 7, 2020

Thanks @atomiix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.