Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for profile ID test #16712

Merged

Conversation

@gavinkalika
Copy link
Contributor

gavinkalika commented Dec 5, 2019

Questions Answers
Branch? develop
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
Type? improvement
Category? TE
BC breaks? NO
Deprecations? NO
Fixed ticket? Issue, please write "Fixes #[issue number]" here.
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

gavin
@gavinkalika gavinkalika requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 5, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 5, 2019

Hello @gavinkalika!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@gavinkalika

This comment has been minimized.

Copy link
Contributor Author

gavinkalika commented Dec 5, 2019

from #16028

@PierreRambaud here is the new branch

@gavinkalika

This comment has been minimized.

Copy link
Contributor Author

gavinkalika commented Dec 9, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 20, 2019

Thank you @gavinkalika for increasing prestashop unit test coverage 👏

@matks matks merged commit 30b604f into PrestaShop:develop Dec 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@gavinkalika

This comment has been minimized.

Copy link
Contributor Author

gavinkalika commented Dec 21, 2019

@matks thanks. where can i go to make bigger contributions on this project?

@gavinkalika gavinkalika deleted the gavinkalika:create-unit-test-for-domain-code branch Dec 21, 2019
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Dec 23, 2019

Hi @gavinkalika, thanks for your contribution!
If you'd like to continue contributing, feel free to take on an bug, there are plenty to choose from 🙂

@matks matks added this to the 1.7.7.0 milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.