Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new connection detection #16733

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@mvorisek
Copy link
Contributor

mvorisek commented Dec 7, 2019

Questions Answers
Branch? develop
Description? Fix/improve new connection detection, presented since at least 1.6.0.x version.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no ticket
How to test? typo fix

The condition is rewriten for better readability, but the effective change is only the added . '/' part.


This change is Reviewable

@mvorisek mvorisek requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 7, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 8, 2019

One more review and merge without QA

@Progi1984 Progi1984 merged commit 2a94af9 into PrestaShop:develop Dec 9, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@mvorisek mvorisek deleted the mvorisek:fix_new_connection_logic branch Dec 9, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.