Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't export data more than filters limits #16742

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 9, 2019

Questions Answers
Branch? 1.7.6.x
Description? Customers, manufacturers and Categories can't be export over the default limit.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16328
How to test? Follow ticket instruction, and repeat with Categories, manufacturers and customers.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.3 milestone Dec 9, 2019
@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 9, 2019
{
$filters = new CategoryFilters(['limit' => null] + CategoryFilters::getDefaults());

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 9, 2019

Contributor

By doing that you ignore all previously set filters in the grid, so the export action will simply return all the categories all the time (regardless of your current filtering) I'd recommend rebuild an object filter based on the provided values:

$filters = new CategoryFilters($filters->all() + ['limit' => null], $filters->getFilterId());
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/16328 branch from 05b3d6e to cc4010e Dec 9, 2019
@jolelievre jolelievre mentioned this pull request Dec 10, 2019
0 of 2 tasks complete
@Progi1984 Progi1984 requested a review from jolelievre Dec 19, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Dec 30, 2019

@jolelievre it's ok for you ?

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 30, 2019

@sarahdib yep all good

@sarahdib sarahdib self-assigned this Jan 8, 2020
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Jan 8, 2020

@PierreRambaud It's fixed for all except for supplier

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 8, 2020

@sarahdib The supplier has not been migrated yet 😅 This is why it's not working yet

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jan 8, 2020
@Progi1984 Progi1984 merged commit ef148c6 into PrestaShop:1.7.6.x Jan 8, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.