Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes bo_css & bo_theme can be empty #16746

Merged
merged 1 commit into from Dec 26, 2019
Merged

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 9, 2019

Questions Answers
Branch? 1.7.6.x
Description? These attributes must not be empty because it prepares some context variables that are used in modules.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16730
How to test? Follow ticket instruction

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 9, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm 👍

@PierreRambaud PierreRambaud dismissed stale reviews from Progi1984 and matthieu-rolland via baccf1b Dec 9, 2019
@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/16730 branch from 2d4c5e3 to baccf1b Dec 9, 2019
@PierreRambaud PierreRambaud changed the title Init.php script must be loaded in admin context bo_css & bo_theme attributes can be empty Dec 9, 2019
@PierreRambaud PierreRambaud changed the title bo_css & bo_theme attributes can be empty Attributes bo_css & bo_theme can be empty Dec 9, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 24, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.3 milestone Dec 24, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 26, 2019

Thank you @PierreRambaud

@matks matks merged commit 3d71c9c into PrestaShop:1.7.6.x Dec 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.