Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behat for Misc group and AddEmployeeHandler. Covers multiple CommandHandlers and QueryHandlers by behat tests #16757

Merged
merged 17 commits into from Dec 20, 2019

Conversation

@tdavidsonas88
Copy link
Contributor

tdavidsonas88 commented Dec 10, 2019

Questions Answers
Branch? develop
Description? cover all CommandHandlers and QueryHandlers by behavior (behat) tests of the group MISC related to #14480
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? #14480
How to test? automated tests should pass

Covered handlers:

Domain/Configuration/CommandHandler/SwitchDebugModeHandler
Domain/ShowcaseCard/CommandHandler/CloseShowcaseCardHandler
Domain/ShowcaseCard/QueryHandler/GetShowcaseCardIsClosedHandler
Domain/MailTemplate/CommandHandler/GenerateThemeMailTemplatesCommandHandler
Domain/Employee/CommandHandler/AddEmployeeHandler


This change is Reviewable

@tdavidsonas88 tdavidsonas88 requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 10, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 10, 2019

Hello @tdavidsonas88!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@tdavidsonas88 tdavidsonas88 changed the title Cover CommandHandlers and QueryHandlers by behat tests [WIP]: Cover CommandHandlers and QueryHandlers by behat tests Dec 16, 2019
@tdavidsonas88 tdavidsonas88 changed the title [WIP]: Cover CommandHandlers and QueryHandlers by behat tests Cover CommandHandlers and QueryHandlers by behat tests Dec 17, 2019
throw new RuntimeException('Properties are invalid');
}
/** @var array $data */
$data = $hash[0];

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud Dec 17, 2019

Contributor
Suggested change
$data = $hash[0];
return $hash[0];
@tdavidsonas88

This comment has been minimized.

Copy link
Contributor Author

tdavidsonas88 commented Dec 17, 2019

@matks @PierreRambaud implemented suggestions after code review.
It would be nice to merge this one because there is a need for domain EmployeeFeatureContext for domain Order features code refactoring which is currently in WIP.

@tdavidsonas88 tdavidsonas88 requested review from PierreRambaud and matks Dec 19, 2019
@matks
matks approved these changes Dec 20, 2019
@matks matks changed the title Cover CommandHandlers and QueryHandlers by behat tests Covers multiple CommandHandlers and QueryHandlers by behat tests Dec 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 20, 2019

Thank you @tdavidsonas88 👏

@matks matks merged commit e3be3a5 into PrestaShop:develop Dec 20, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@tdavidsonas88 tdavidsonas88 deleted the tdavidsonas88:feature/misc=integration-tests branch Dec 20, 2019
@matks matks added this to the 1.7.7.0 milestone Dec 26, 2019
@tdavidsonas88 tdavidsonas88 changed the title Covers multiple CommandHandlers and QueryHandlers by behat tests Behat for Misc group and AddEmployeeHandler. Covers multiple CommandHandlers and QueryHandlers by behat tests Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.