Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix recursive check of updated files #16765
The return value of the recursive call is not used, so even if it
The URL to the xml file was incorrect, so it never got to the recursive
The return value of the recursive call is not used, so even if it reports changed files in subfolders, they won't be returned at the end. The URL to the xml file was incorrect, so it never got to the recursive call in the first place.
Did you make sure that
Unfortunately, there are a few things that might fail with loading the XML and there is no error message shown to the user. This is a separate improvement that could be made, but a decision regarding the UI and the wording should be made.
So to test this PR, please make sure it loads the xml file successfully and that the modified file is present in the list of files in the XML.