Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: update config for dpl v2 #16807

Merged
merged 1 commit into from Dec 30, 2019

Conversation

@mvorisek
Copy link
Contributor

mvorisek commented Dec 13, 2019

Questions Answers
Branch? develop
Description? No functionality change, only update travis config to remove warnings, i.e. update config based on the latest config grammar.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Travis jobs need to pass with same output as the previous build.

Before:
image
image
image

After:
image


This change is Reviewable

@mvorisek mvorisek requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 13, 2019
@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Dec 14, 2019

image
How to solve it? Please review and merge.

@matks matks closed this Dec 20, 2019
@matks matks reopened this Dec 20, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 20, 2019

@mvorisek Sorry for late answer. As our CI relies on external 3rd party, payloads sometimes get lost 😅 so I closed and reopend the PR in order to re-send some payloads to both PrettyCI and Travis. I hope this one the payloads and their answers will reach destination.

@matks
matks approved these changes Dec 20, 2019
@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Dec 20, 2019

@matks

@mvorisek Sorry for late answer. As our CI relies on external 3rd party, payloads sometimes get lost 😅 so I closed and reopend the PR in order to re-send some payloads to both PrettyCI and Travis. I hope this one the payloads and their answers will reach destination.

The PrettyCI seems to be still broken. TravisCI passed, no PHP code (which should be the only code PrettyCI checks) changed.

Can you merge and watch if the merge commit will pass all checks?

PS: reported, at the time of writing this message, to Pretty CI via contact form

@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Dec 21, 2019

@matks Here is a reply from Matthieu from the PrettyCI owner:

Hello Michael,

Sorry about that. I had a look in several different places and it seems that the HTTP call to the GitHub API that triggers the build on the fork failed.
I deployed a small change that hopefully will fix it. Are you able to restart the build manually in the GitHub UI?

Matthieu

@matks matks closed this Dec 21, 2019
@matks matks reopened this Dec 21, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 21, 2019

Reclosing and reopening again in order to see if issue with PrettyCI is fixed now

Thanks for the investigation @mvorisek 👍

@mvorisek mvorisek closed this Dec 23, 2019
@mvorisek mvorisek reopened this Dec 23, 2019
@mnapoli

This comment has been minimized.

Copy link

mnapoli commented Dec 23, 2019

@matks thank you for your patience, I finally managed to re-trigger the check suite manually (I'm not proud how I did, that involved some curl, ID hardcoding in the codebase and redelivering of webhooks 😅)

Hopefully everything is good now.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 30, 2019

Thank you @mvorisek for the travis config and @mnapoli for the debug in prod (dont worry, it happened (happens ?) to all of us !)

@matks matks merged commit dc966cc into PrestaShop:develop Dec 30, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@mvorisek mvorisek deleted the mvorisek:gh_fix_travis_yml_grammar branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.