Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide new migrated Catalog > Files Symfony page #16815

Merged
merged 3 commits into from Dec 16, 2019

Conversation

@matks
Copy link
Contributor

matks commented Dec 14, 2019

Questions Answers
Branch? develop
Description? Unhide new migrated Catalog > Files Symfony page and plug legacy_links for redirections
Type? new feature
Category? BO
BC breaks? yes, legacy controller files are removed
Deprecations? no
Fixed ticket? Fixes 1 item of #10550
How to test? Please check that now all links to Catalog > Files redirect to migrated page instead of legacy page

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 14, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 14, 2019

Thank you @RaimondasSapola for providing the legacy_links, I only needed to activate them !

@matks matks mentioned this pull request Dec 15, 2019
4 of 33 tasks complete
…rtions, remove phpunit-routing which is now useless
Copy link
Contributor

jolelievre left a comment

Thank you @matks

@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Dec 16, 2019
@matks matks added the migration label Dec 16, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Dec 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 16, 2019

Thanks for review

@matks matks closed this Dec 16, 2019
@matks matks reopened this Dec 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 16, 2019

(I clicked on "close" instead of "merge", damned, gonna need to wait for travis again)

@@ -38,7 +38,7 @@ admin_webservice_keys_edit:
_legacy_controller: AdminWebservice
_legacy_link: AdminWebservice:updatewebservice_account
_legacy_parameters:
id_webservice_account: webserviceAccountId
id_webservice_account: webserviceKeyId

This comment has been minimized.

Copy link
@matks

matks Dec 16, 2019

Author Contributor

🤔 I dont remember adding this in my PR ?

This comment has been minimized.

Copy link
@matks

matks Dec 16, 2019

Author Contributor

@jolelievre aaaaah 😅you added that

Ouf, I thought I was becoming crazy 😃

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 16, 2019

Contributor

Yes I added a few tests in url coverter tests, which highlighted some wrong parameters ^^

@matks matks merged commit 5b605f4 into PrestaShop:develop Dec 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks deleted the matks:unhide-catalog-files branch Dec 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 16, 2019

Thanks for review @PierreRambaud and for the fixes @jolelievre !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.