Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty states for Catalog > Files and Orders > Credit slips pages #16821

Merged
merged 2 commits into from Dec 19, 2019

Conversation

@matks
Copy link
Contributor

matks commented Dec 15, 2019

Questions Answers
Branch? develop
Description? Add empty states for Catalog > Files and Orders > Credit slips pages
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes 1 item of #10550 and 1 item of #10581
How to test? Please check that pages Catalog > Files and Orders > Credit slips, when they have no records, the empty state is displayed with right informations (see #10434 for full specs). No need to rebuild assets.

Please note that Catalog > Files migrated page is hidden right now so you need to access it directly through the URL /admin-dev/index.php/sell/attachments/


This change is Reviewable

@matks matks added the migration label Dec 15, 2019
@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 15, 2019
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 15, 2019

@TristanLDD @prestascott I see that "Suppliers" empty state (see #10434) uses a SVG image instead of a PNG. I used the PNG available on Invision for these 2 pages, is this OK ? If you prefer SVG, please send them to me so I can replace them 😉

@TristanLDD

This comment has been minimized.

Copy link

TristanLDD commented Dec 16, 2019

@matks Helper cards use PNG so yes let's stick to that for empty states as well 👍

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 19, 2019

Hi @matks !

There is a difference between specs and this PR on "Catalog > Files".

In the specs (https://docs.google.com/document/d/1e_yu6f3Eq1c430k-a2QA9WLZwbwRSPsIeM_jhp09Jdg/edit) :
"Make some files available to your customers before their purchase, facilitate their purchasing environment by adding them just here! It can be instruction manuals, technical works or anything you want to attach to a product."

For credit slip it is OK.

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Dec 19, 2019

Hi @matks !

There is a difference between specs and this PR on "Catalog > Files".

In the specs (https://docs.google.com/document/d/1e_yu6f3Eq1c430k-a2QA9WLZwbwRSPsIeM_jhp09Jdg/edit) :
"Make some files available to your customers before their purchase, facilitate their purchasing environment by adding them just here! It can be instruction manuals, technical works or anything you want to attach to a product."

For credit slip it is OK.

I initially copy-pasted the message but @LouiseBonnard asked to modify it (see here feedback above).
@LouiseBonnard can you confirm the wording should be the feedback you gave, and not the one from the specs ?

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 19, 2019

@matks, I confirm, it's all fine! I've slightly modified it when reviewing the PR to make it clearer. :-)

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 19, 2019

Okay @LouiseBonnard ! Could you update the specs with the new wording ? Thanks :)

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 19, 2019

@Robin-Fischer-PS, done, thanks!

@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Dec 19, 2019

So it's QA ✔️

Thanks all :)

@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Dec 19, 2019
@Progi1984 Progi1984 merged commit ea056f7 into PrestaShop:develop Dec 19, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks deleted the matks:add-2-empty-states branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.