Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show list bullets on product page and align it #16856

Merged
merged 2 commits into from Jan 2, 2020

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Dec 18, 2019

Questions Answers
Branch? develop
Description? Bullets where hidden on product page when PO team thinks if people use it in BO they wants to see these on the page
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15498
How to test? Put a list with items on a product description and see if bullets are on the product page description. Please rebuild assets.

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 18, 2019
@sarahdib

This comment has been minimized.

Copy link

sarahdib commented Dec 19, 2019

@NeOMakinG the indent is missing
Capture d’écran 2019-12-19 à 12 51 19

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 30, 2019

Conflict on assets

  • for QA team: please rebuild assets 😄
  • after QA we need to rebase and rebuild
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Dec 31, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Dec 31, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 1, 2020

@NeOMakinG one rebase to get rid of the git conflict, and we can merge 😄

@NeOMakinG NeOMakinG force-pushed the NeOMakinG:issue15498 branch from b3767e3 to 3b45540 Jan 2, 2020
@NeOMakinG

This comment has been minimized.

Copy link
Contributor Author

NeOMakinG commented Jan 2, 2020

Should be fine now, thanks @sarahdib @matks

@NeOMakinG NeOMakinG force-pushed the NeOMakinG:issue15498 branch from 3b45540 to 4530a30 Jan 2, 2020
@matks
matks approved these changes Jan 2, 2020
Copy link

photinia73 left a comment

Hello!
Unfortunately thees changes didn't help. The list has the same look.
image
I made the changes in the my Theme but nothing happend...

@NeOMakinG

This comment has been minimized.

Copy link
Contributor Author

NeOMakinG commented Jan 2, 2020

@photinia73 unfortunately it should be related to your theme

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 2, 2020

@photinia73 can we see your theme online ? is it inspired / a child of classic theme ?

@photinia73

This comment has been minimized.

Copy link

photinia73 commented Jan 2, 2020

https://te.com.ua/uk/stereo-pidsilyuvachi-integralni/2635-marantz-pm7000n.html
If you need access to ftp to see the Theme code give me please your e-mail. This is the Theme by HiddenTechies

@photinia73

This comment has been minimized.

Copy link

photinia73 commented Jan 2, 2020

At last it work! But in the such way
.product-description ul {
list-style: inherit;
list-style-position: inside;
padding-left: 1.75rem;
}
and only from file themes/pixtronpro/assets/css/custom.css
from this file themes/classic/_dev/css/components/products.scss no effect....

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 2, 2020

At last it work! But in the such way
.product-description ul {
list-style: inherit;
list-style-position: inside;
padding-left: 1.75rem;
}
and only from file themes/pixtronpro/assets/css/custom.css
from this file themes/classic/_dev/css/components/products.scss no effect....

SCSS files are actually source code that needs to be compiled 😉see SASS and PrestaShop assets compilation

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 2, 2020

Thank you @NeOMakinG

@matks matks merged commit 106dc07 into PrestaShop:develop Jan 2, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@photinia73

This comment has been minimized.

Copy link

photinia73 commented Jan 2, 2020

WOW, so many interesting news, will learn! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.