Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix United Kingdom VAT issue for all EU countries #16860

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@jf-viguier
Copy link
Contributor

jf-viguier commented Dec 19, 2019

Questions Answers
Branch? develop
Description? The United Kingdom is not associated to EU Vat tax rule groups because the iso code in xml files is uk and should be gb
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12514
How to test? Go to taxes and see than Uk is not in VAT country list of EU countries

This change is Reviewable

@jf-viguier jf-viguier requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 19, 2019
@LouiseBonnard LouiseBonnard mentioned this pull request Dec 19, 2019
19 of 23 tasks complete
@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 19, 2019

Nice catch, @jf-viguier! You're right: since the United Kingdom is localized in PrestaShop under the 'gb' country code, its tax rates must be mentioned under the same code.

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Dec 19, 2019

Thanks @LouiseBonnard
What's the solution to fix it for already installed prestashop ? The xml is not reloaded. Maybe an sql in next upgrade ?

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 19, 2019

Here is documentation that should help you. ;-)

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Dec 19, 2019

This link ask for a password that I don't have.

@jf-viguier jf-viguier changed the title Fix United Kindom VAT issue for all EU countries Fix United Kingdom VAT issue for all EU countries Dec 20, 2019
@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 20, 2019

Oops, sorry... you will still have to wait for the 1.7.7 release but if you want older PrestaShop versions to benefit from updated localization packs, know that they are also distributed through our services via http://api.prestashop.com/localization/{majorVersion}/{countryIsoCode}.xml (where {majorVersion} is something like "17" (for 1.7) and {countryIsoCode} is a 2-letter country iso code like "fr").

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Dec 20, 2019

@LouiseBonnard how can we fix the files delivered by http://api.prestashop.com ?

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Dec 20, 2019

@matks, any idea of a workaround?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 20, 2019

To fix a shop, it's necessary to fix the file content and clear the cache.
I think api.prestashop.com could be hotfixed to provide the right file if this is an important issue (ping @eternoendless)

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 20, 2019

@LouiseBonnard so this PR has your approval ? 😄

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Dec 23, 2019

This file will be available for download directly from the API once we update it in https://github.com/PrestaShop/LocalizationFiles. To get the latest file directly from your BO, you need to go to International > Localization > Import localization pack; then you choose the country, check taxes only, make sure that the "download localization data" switch is in ON, then click on import. That should do it.

I haven't tested it myself, but if that doesn't work it's a bug.

Copy link
Member

eternoendless left a comment

Looks good

@eternoendless eternoendless added this to the 1.7.7.0 milestone Dec 23, 2019
@johanlantz

This comment has been minimized.

Copy link

johanlantz commented Jan 10, 2020

Any idea when this will be available. I just discovered that all UK orders since the 1.7.6 update has gone through without the customers paying IVA. Our shop is small but its still a very serious issue.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 10, 2020

@johanlantz It will be available in few weeks :)

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jan 10, 2020
@Progi1984 Progi1984 merged commit bdc3caf into PrestaShop:develop Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 10, 2020

Thanks @jf-viguier

@jf-viguier

This comment has been minimized.

Copy link
Contributor Author

jf-viguier commented Jan 10, 2020

@Progi1984 u're welcome

@jf-viguier jf-viguier deleted the jf-viguier:fixes-uk-vat-issue branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.