Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yml config parse typo #16893

Merged
merged 1 commit into from Dec 26, 2019

Conversation

@mvorisek
Copy link
Contributor

mvorisek commented Dec 21, 2019

Questions Answers
Branch? 1.7.6.x
Description? Fix yml config parse typo
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? All tests must pass.

This change is Reviewable

@mvorisek mvorisek requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 21, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 22, 2019

Copy link
Contributor

matthieu-rolland left a comment

lgtm for me too @PierreRambaud , thank you for your contribution @mvorisek 👍

@matthieu-rolland matthieu-rolland merged commit 30089be into PrestaShop:1.7.6.x Dec 26, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@mvorisek mvorisek deleted the mvorisek:gh_fix_bootstrap_typo branch Dec 26, 2019
@matks matks added this to the 1.7.6.3 milestone Dec 26, 2019
@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Jan 1, 2020

When will this PR be merged into develop? Is there any general rule like when a release from the target branch is made?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 1, 2020

When will this PR be merged into develop? Is there any general rule like when a release from the target branch is made?

We regularly perform merges of branch 1.7.6.x into develop, but the frequency is not asserted. We do it every 2 or 3 days when enough commits are waiting for it. Example of such PR #16596

EDIT: as it's holidays season, the frequency dropped a lot 😁

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 1, 2020

Just created a PR to perform the merge: #17000

@mvorisek

This comment has been minimized.

Copy link
Contributor Author

mvorisek commented Jan 1, 2020

@matks Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.