Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Fix tests : invoices options #16897

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Dec 23, 2019

Questions Answers
Branch? develop
Description? Fix tests invoices options
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? DOWNLOAD_PATH="Download_path" TEST_PATH="functional/BO/orders/invoices/03_invoiceOptions/*" URL_FO=SHOP_URL npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Dec 23, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 23, 2019
@@ -27,9 +27,9 @@ module.exports = class Order extends BOBasePage {
this.documentNumberLink = '#documents_table tr:nth-child(%ID) td:nth-child(3) a';
this.documentName = '#documents_table tr:nth-child(%ID) td:nth-child(2)';
// Refund form
this.refundProductQuantity = `${this.orderProductsTable} tr:nth-child(%ID)
this.refundProductQuantity = `${this.orderProductsTable} tr:nth-child(%ID)

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 23, 2019

Contributor

The string is written on two lines? Wouldn't it be better on a single line?

This comment has been minimized.

Copy link
@boubkerbribri

boubkerbribri Dec 23, 2019

Author Contributor

max-len = 120 for eslint, and we have an error if we make the selector in a single line

This comment has been minimized.

Copy link
@jolelievre

jolelievre Dec 23, 2019

Contributor

That's what I figured, I just thought the syntax was weird, but as long as as it works correctly

@SimonGrn SimonGrn merged commit ba7272b into PrestaShop:develop Dec 23, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@matks matks added this to the 1.7.7.0 milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop 1.7.7
  
Awaiting triage
5 participants
You can’t perform that action at this time.