Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad wording when installation check #16941

Merged

Conversation

@gavinkalika
Copy link
Contributor

gavinkalika commented Dec 27, 2019

Questions Answers
Branch? develop
Description? configuration
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16859
How to test? Perform an incorrect installation to get prompted with new message

This change is Reviewable

gavinkalika and others added 2 commits Dec 27, 2019
Update dev
@gavinkalika gavinkalika requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 27, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 27, 2019

Hello @gavinkalika!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@gavinkalika

This comment has been minimized.

Copy link
Contributor Author

gavinkalika commented Dec 27, 2019

@matks
matks approved these changes Dec 30, 2019
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Jan 3, 2020
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Jan 3, 2020
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Jan 3, 2020

Thanks @gavinkalika 😄

@matks matks merged commit 767a9b7 into PrestaShop:develop Jan 3, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.