Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the string in success alert for attachements bulk deletion #16946

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@arouiadib
Copy link
Contributor

arouiadib commented Dec 28, 2019

Modified the string from "Successful deletion." to "The selection has been successfully deleted."

Questions Answers
Branch? develop
Description?
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16921
How to test? Go to the BO => Catalog => files (you should have more than one file). Try to delete files with Bulk action, and see the success alert string.

This change is Reviewable

Modified the string from "Successful deletion." to "The selection has been successfully deleted."
@arouiadib arouiadib requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 28, 2019
@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 28, 2019

Hello @arouiadib!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@arouiadib arouiadib changed the title Modified the string in success alert for file bulk deletion Modified the string in success alert for attachements bulk deletion Dec 28, 2019
@matks
matks approved these changes Dec 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 30, 2019

Code is
Let's wait for QA to validate the behavior

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 3, 2020

Thank you @arouiadib

@matks matks merged commit 2ab0dd3 into PrestaShop:develop Jan 3, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@arouiadib

This comment has been minimized.

Copy link
Contributor Author

arouiadib commented Jan 3, 2020

You made my day @matks by this first-ever merge in PrestaShop as and amazing project, and in open source as a whole. Big thanks!

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 4, 2020

You made my day @matks by this first-ever merge in PrestaShop as and amazing project, and in open source as a whole. Big thanks!

I did nothing, you did all the work 😉thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.