Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - add test 'filter languages' #16963

Merged
merged 7 commits into from Jan 7, 2020

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Dec 30, 2019

Questions Answers
Branch? develop
Description? Add new functional test : Filter Languages table
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="functional/BO/international/localization/languages/01_filterLanguages.js" URL_FO=Shop_URL npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Dec 30, 2019
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Dec 30, 2019
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Dec 30, 2019
@boubkerbribri boubkerbribri requested a review from jolelievre Jan 6, 2020
Copy link
Contributor

jolelievre left a comment

Nice @boubkerbribri
Although I was thinking maybe you could have a parent class for all the subtabs from this Localization page?
Since the tab ids and the goToSubTab* functions are always the same, this way you would only need to modify/fix one file

@SimonGrn SimonGrn merged commit 39de864 into PrestaShop:develop Jan 7, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.