Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16997 - assertion of first/classic theme from unsorted list #16998

Merged

Conversation

@mvorisek
Copy link
Contributor

mvorisek commented Jan 1, 2020

Questions Answers
Branch? develop
Description? Fixes #16997 - Unit tests from FolderThemeCatalogTest class are failing
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16997
How to test? All tests need to pass.

Issue introduced at 1.7.6.x as 1.7.5.x does not contain modern/multiple mail themes. Please merge into 1.7.6.x and develop asap. Thanks.


This change is Reviewable

@mvorisek mvorisek requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 1, 2020
Copy link
Contributor

Progi1984 left a comment

Need a second review

@PierreRambaud PierreRambaud merged commit 2a2aa83 into PrestaShop:develop Jan 8, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 8, 2020

Thanks @mvorisek

@PierreRambaud PierreRambaud added develop and removed 1.7.6.x labels Jan 8, 2020
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jan 8, 2020
@mvorisek mvorisek deleted the mvorisek:gh_fix_classic_theme_assert branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.