Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting price alignment on RTL language #17002

Merged
merged 1 commit into from Jan 2, 2020
Merged

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Jan 2, 2020

Questions Answers
Branch? develop
Description? Prices were buggy on the homepage while using an RTL language
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13934
How to test? Go on the home page with rtl language with a currency with more than 3 letters like USD, and see if prices are well aligned

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 2, 2020
@matks
matks approved these changes Jan 2, 2020
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 2, 2020

Thank you @NeOMakinG

@matks matks merged commit 7cdb8f9 into PrestaShop:develop Jan 2, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.