Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default "Select" when sort not up in FO is selected on category page #17005

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Jan 2, 2020

Questions Answers
Branch? develop
Description? Empty select box in category page when a sort type is not up in FO
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14210
How to test? Go to backoffice> preferences > products, select sort order which is not avaiable on frontoffice and then verify that in category page there is "Select" or anything else instead of an empty box

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 2, 2020
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Jan 7, 2020
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.7.0 milestone Jan 7, 2020
@Progi1984 Progi1984 merged commit eca5718 into PrestaShop:develop Jan 7, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 7, 2020

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.