Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Fix supplier name and zip code #17006

Merged

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Jan 2, 2020

Questions Answers
Branch? develop
Description? Fix supplier faker data for name (less than 64 characters) and zip code (cannot contain '.')
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="functional/BO/catalog/brandsAndSuppliers/suppliers/*" URL_FO=Shop_Url npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Jan 2, 2020
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Jan 2, 2020
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 2, 2020
Copy link
Contributor

matthieu-rolland left a comment

lgtm

@matthieu-rolland matthieu-rolland merged commit 4e3feb7 into PrestaShop:develop Jan 2, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.