Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore rtl assets and remove _rtl.css files #17030

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Jan 6, 2020

Questions Answers
Branch? 1.7.6.x
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Doesnt fix a ticket, fixing that _rtl.css files shouldnt be on the repo/release package
How to test? Nothing to verify except that _rtl.css files shouldnt be present in classic theme assets

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 6, 2020
@PierreRambaud PierreRambaud merged commit c7b3077 into PrestaShop:1.7.6.x Jan 8, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 8, 2020

No need QA, Thanks @NeOMakinG

@PierreRambaud PierreRambaud added this to the 1.7.6.3 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.