Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests - Add new test 'Crud language test' #17052

Merged
merged 6 commits into from Jan 8, 2020

Conversation

@boubkerbribri
Copy link
Contributor

boubkerbribri commented Jan 7, 2020

Questions Answers
Branch? develop
Description? Add new functional test Crud language test
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="functional/BO/international/localization/languages/02_CRUDLanguage" URL_FO=Shop_Url npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE label Jan 7, 2020
@boubkerbribri boubkerbribri added this to the 1.7.7.0 milestone Jan 7, 2020
@boubkerbribri boubkerbribri requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 7, 2020
* @param lang
* @return {Promise<boolean|true>}
*/
async languageExist(lang = 'en') {

This comment has been minimized.

Copy link
@Progi1984

Progi1984 Jan 8, 2020

Contributor
Suggested change
async languageExist(lang = 'en') {
async languageExists(lang = 'en') {

This comment has been minimized.

Copy link
@boubkerbribri

boubkerbribri Jan 8, 2020

Author Contributor

done thanks

Copy link
Contributor

Progi1984 left a comment

A small change

@boubkerbribri boubkerbribri requested a review from Progi1984 Jan 8, 2020
@SimonGrn SimonGrn merged commit 8b6a970 into PrestaShop:develop Jan 8, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.