Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding on product name in viewed product #17065

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Jan 8, 2020

Questions Answers
Branch? 1.7.6.x
Description? Fixed encoding on product name in viewed product
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16739
How to test? From @khouloudbelguith in comment :
1. Add the Russian language
2. Edit the language employee to Russian
3. Add some product with a Russian name for example (СВИТЕР С КОЛИБРИ)
3.1 Add some product with accent ("T-shirt imprimé colibri"
4. Go to the FO, sign in with Customer C & add this product to cart
5. Go to the BO => Customer => View this customer
6. Check the Viewed Products section
image

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 8, 2020
@atomiix
atomiix approved these changes Jan 9, 2020
Copy link
Contributor

atomiix left a comment

LGTM

@PierreRambaud PierreRambaud added this to the 1.7.6.3 milestone Jan 9, 2020
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Jan 10, 2020
@eternoendless eternoendless merged commit c869d04 into PrestaShop:1.7.6.x Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jan 10, 2020

Thank you @Progi1984

@eternoendless eternoendless mentioned this pull request Jan 10, 2020
@eternoendless eternoendless changed the title Fixed encoding on product name in viewed product Fix encoding on product name in viewed product Jan 10, 2020
@Progi1984 Progi1984 deleted the Progi1984:issue16739 branch Jan 10, 2020
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 13, 2020

Hi guys, sorry for being late at the party, isn't it risky to remove this sanitization step ? Do you consider the product name to be 100% safe ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.