Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive check of updated files - backport of #16765 #17071

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@matks
Copy link
Contributor

matks commented Jan 8, 2020

Questions Answers
Branch? 1.7.6.x
Description? Backport of #16765 which fixes the RequiredFilesChecker
Type? bug fix
Category? BO
BC breaks? No
Deprecations? No
Fixed ticket?
How to test? See #16765

This change is Reviewable

The return value of the recursive call is not used, so even if it
reports changed files in subfolders, they won't be returned at the end.

The URL to the xml file was incorrect, so it never got to the recursive
call in the first place.
@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 8, 2020
@matks matks added the waiting for QA label Jan 8, 2020
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 8, 2020

This fix has been backported from 1.7.7.x to 1.7.6.x as it fixes an important regression

@PierreRambaud PierreRambaud added this to the 1.7.6.3 milestone Jan 8, 2020
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Jan 10, 2020

Thanks @matks for the PR, and thanks @Progi1984 for the help for the test, it's QA ✔️ :)

@Progi1984 Progi1984 merged commit 4a2ee23 into PrestaShop:1.7.6.x Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 10, 2020

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.