Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve modal object without using this #17079

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Jan 9, 2020

Questions Answers
Branch? develop
Description? Code quality of modal wasnt at his best
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Noone
How to test? Go on /admin-dev/index.php/sell/attachments/?_token=pMf66fXNkQOtMt9aWrFAuicO80ucFRUUhONYp9KpzvU , add some files and try to delete with bulk action, this pr is improvement of code quality of the modal

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 9, 2020
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jan 10, 2020
@sarahdib sarahdib added this to the 1.7.7.0 milestone Jan 10, 2020
@Progi1984 Progi1984 merged commit 39a59e9 into PrestaShop:develop Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Jan 10, 2020

Thanks @NeOMakinG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.