Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define alert message when error are found in Category Form #17087

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Jan 9, 2020

Questions Answers
Branch? 1.7.6.x
Description? Define alert message when error are found in Category Form
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16514
How to test? Case1:
1. Go to Catalog -> Category
2. Click on Modify on a category already created
3. Scroll down to "Keywords"
4. Add new keywords with max length > 255 chars
5. Save
6. A readable error is displayed

Case2:
1. Check that the Accented URL is disabled
2. Create a new category with an invalid Friendly URL for example child.1
3. A readable error is displayed

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers as a code owner Jan 9, 2020
@Progi1984 Progi1984 added this to the 1.7.6.3 milestone Jan 9, 2020
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Jan 10, 2020

Hi @Progi1984 !

Your fix is OK when editing a category (a clear error message is displayed), but when creating a new category, I still have the unclear message (for both Keywords and Friendly URL messages) :
PR17087 creation error

@Progi1984 Progi1984 force-pushed the Progi1984:issue16514 branch from 990afba to 1e0e81d Jan 10, 2020
Copy link
Contributor

atomiix left a comment

LGTM !

@matthieu-rolland matthieu-rolland merged commit 0d09b91 into PrestaShop:1.7.6.x Jan 10, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue16514 branch Jan 10, 2020
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 10, 2020

Thank you @Progi1984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.