Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug on safari where SEO preview on create page was not updated #17711

Merged
merged 4 commits into from Feb 28, 2020

Conversation

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Feb 18, 2020

Questions Answers
Branch? 1.7.6.x
Description? SEO Preview while creating a page was broken, it was not working
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #17525
How to test? Build assets, and then create a page and type in title, SEO should be updated

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from PrestaShop/prestashop-core-developers as a code owner Feb 18, 2020
@NeOMakinG NeOMakinG changed the base branch from develop to 1.7.6.x Feb 18, 2020
Copy link
Contributor

matthieu-rolland left a comment

LGTM, but for some reason you have pretty CI issues on files you didn't touch 🤔

Maybe you need to rebase ?

NeOMakinG added 2 commits Feb 18, 2020
This reverts commit 2458553.
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Feb 21, 2020

Need a rebase @NeOMakinG

@matks
matks approved these changes Feb 21, 2020
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Feb 21, 2020

Re running PrettyCI

@NeOMakinG

This comment has been minimized.

Copy link
Contributor Author

NeOMakinG commented Feb 26, 2020

To QA : It can be tested and @eternoendless will merge it without PrettyCI which is crying

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Feb 27, 2020

Hi @NeOMakinG,

It is OK os => OS+X => os_version=High+Sierra => browser=>Safari & browser_version=>11.1
https://drive.google.com/file/d/1Ea0hZfvAKt6PfJN1hREqA2FT16NnHlUp/view

PS: using iOS9 => issue reproduced
image
But, this is won't be fixed which is simlar to this case: #17403

Thanks!

@khouloudbelguith khouloudbelguith added this to the 1.7.6.4 milestone Feb 27, 2020
@atomiix

This comment has been minimized.

Copy link
Contributor

atomiix commented Feb 27, 2020

@eternoendless I think you can merge as it's QA approuved!

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Feb 28, 2020

Thank you @NeOMakinG

@eternoendless eternoendless merged commit 2920d6d into PrestaShop:1.7.6.x Feb 28, 2020
1 of 2 checks passed
1 of 2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.