Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new wording without domain #17796

Merged

Conversation

@eternoendless
Copy link
Member

eternoendless commented Feb 24, 2020

Questions Answers
Branch? 1.7.7.x
Description? A new wording added in #12855 did not have the appropriate translation domain
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Nothing to test

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.7.0 milestone Feb 24, 2020
@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner Feb 24, 2020
@eternoendless

This comment has been minimized.

Copy link
Member Author

eternoendless commented Feb 24, 2020

While I agree that we should update all wordings without domain, I think it would be more suitable to do them all at once in a different PR. This PR is supposed to update only the newly added wording.

eternoendless added a commit to jolelievre/PrestaShop that referenced this pull request Feb 24, 2020
@matks
matks approved these changes Feb 24, 2020
@matthieu-rolland matthieu-rolland merged commit 80f13a4 into PrestaShop:1.7.7.x Feb 24, 2020
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.