Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct generatorRuntime on new-theme to fix an error on add currency page #17923

Merged
merged 2 commits into from Mar 25, 2020
Merged

Correct generatorRuntime on new-theme to fix an error on add currency page #17923

merged 2 commits into from Mar 25, 2020

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Mar 2, 2020 •
edited

Questions Answers
Branch? develop
Description? Add currency page was poping a 500 error due to the fact that we used generatorRuntime without a transpiler plugin for it
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #17397.
How to test? Pull, build new-theme assets
1. Go to the BO => International => Localization => Currencies page
2. Add a new currency => en error in the console
3. Select a currency
4. See error: the pop up is not displayed
5. Complete all fields
6. Save and it should works like expected

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner March 2, 2020 14:54
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Mar 2, 2020
@NeOMakinG NeOMakinG changed the title Correct generatorRuntime so you could use await/async Correct generatorRuntime on new-theme to fix an error on add currency page Mar 2, 2020
@NeOMakinG NeOMakinG requested a review from a team March 3, 2020 15:20
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Mar 3, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Mar 4, 2020
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 24, 2020
@matks
Copy link
Contributor

matks commented Mar 25, 2020

Thank you @NeOMakinG

@matks matks merged commit 0ebe142 into PrestaShop:develop Mar 25, 2020
@matks matks mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

The pop up is not displayed when adding a new currency
7 participants
@NeOMakinG @matks @PierreRambaud @matthieu-rolland @Progi1984 @sarahdib @prestonBot