Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code #19535

Merged
merged 1 commit into from Jun 3, 2020
Merged

Remove unused code #19535

merged 1 commit into from Jun 3, 2020

Conversation

idnovate
Copy link
Contributor

@idnovate idnovate commented Jun 2, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Unused code
Type? improvement
Category? FO
BC breaks? yes
Deprecations? yes
Fixed ticket? Fixes #19531

This change is Reviewable

@idnovate idnovate requested a review from a team as a code owner June 2, 2020 16:42
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 2, 2020
@NeOMakinG
Copy link

Running travis again as it's red

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Jun 3, 2020
@matks
Copy link
Contributor

matks commented Jun 3, 2020

Thank you @idnovate

@matks matks merged commit 69fe5fe into PrestaShop:develop Jun 3, 2020
@idnovate idnovate deleted the remove-code branch September 23, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Useless code: $cart_rules & $available_cart_rules declared but unused
5 participants
@idnovate @NeOMakinG @matks @PierreRambaud @prestonBot