Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert change from #18220, it breaks modules #20182

Merged
merged 1 commit into from Jul 15, 2020
Merged

Revert change from #18220, it breaks modules #20182

merged 1 commit into from Jul 15, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jul 15, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Revert from https://github.com/PrestaShop/PrestaShop/pull/18220/files#diff-242ffc26fde8f0971306f9172447bc6dR178, it's a BC as you can see in the screenshot from the psgdpr module
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? No need QA

image
.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner July 15, 2020 13:54
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jul 15, 2020
@matks matks merged commit f299969 into PrestaShop:develop Jul 15, 2020
@matks matks added this to the 1.7.8.0 milestone Jul 15, 2020
@PierreRambaud PierreRambaud deleted the revert-bc branch July 15, 2020 15:24
@mikeKstm mikeKstm mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PierreRambaud @Progi1984 @matthieu-rolland @matks @prestonBot