Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FormSubmitButton method #20508

Merged
merged 2 commits into from Sep 7, 2020
Merged

Fix FormSubmitButton method #20508

merged 2 commits into from Sep 7, 2020

Conversation

davidglezz
Copy link
Contributor

@davidglezz davidglezz commented Aug 8, 2020 •
edited by Progi1984

Questions Answers
Branch? develop
Description? 1. Fix form method: Before, always 'POST' (I think it was lost in some Merge)
2. Fix _method value to btnMethod. Previously only GET or POST even if the button had another
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? #20508 (comment)

This change is Reviewable

@davidglezz davidglezz requested a review from a team as a code owner August 8, 2020 17:21
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Aug 8, 2020
@Progi1984
Copy link
Contributor

@davidglezz Thank you for your contribution. 🤗

Could you give us a scenario which permits to test the bug before and after this PR ?

Thanks 👍

@Progi1984 Progi1984 added the Waiting for author Status: action required, waiting for author feedback label Sep 3, 2020
@davidglezz
Copy link
Contributor Author

It is an improvement, which could prevent current and future bugs. I made this improvement theoretically because when I saw the code I did not see it coherent.

It would be necessary to verify that the pages that use it continue to work well.

It is currently used in 4 pages to delete items.

  • Delete product from brands
    image
  • Delete address Dropdown
  • Delete Category thumbnail
  • Delete Category cover

Find js-form-submit-btn
https://github.com/PrestaShop/PrestaShop/search?q=js-form-submit-btn&unscoped_q=js-form-submit-btn

@Progi1984 Progi1984 added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels Sep 4, 2020
@Progi1984
Copy link
Contributor

@davidglezz Ok for me. I send it to QA (I updated your PR).

@khouloudbelguith khouloudbelguith self-assigned this Sep 7, 2020
@khouloudbelguith
Copy link
Contributor

Hi @davidglezz,

It is ok ✔️
https://drive.google.com/file/d/1m68NyHuEQB3BJFqhtcBYim4dNzzgkFTe/view?usp=sharing
Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 7, 2020
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@khouloudbelguith khouloudbelguith added this to the 1.7.8.0 milestone Sep 7, 2020
@khouloudbelguith khouloudbelguith added this to To be merged in PrestaShop 1.7.8.0 Sep 7, 2020
@Progi1984 Progi1984 merged commit e2dce51 into PrestaShop:develop Sep 7, 2020
@Progi1984
Copy link
Contributor

Thanks @davidglezz & @khouloudbelguith

@Progi1984 Progi1984 moved this from To be merged to Done in PrestaShop 1.7.8.0 Sep 7, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@atomiix atomiix atomiix approved these changes

Assignees

@khouloudbelguith khouloudbelguith

Labels
Bug Type: Bug develop Branch Fixed Resolution: issue closed because fixed QA ✔️ Status: check done, code approved
Projects
No open projects
PrestaShop 1.7.8.0
  
Done
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidglezz @Progi1984 @khouloudbelguith @prestonBot @atomiix