Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc comments to reflect actual signatures #20658

Merged
merged 1 commit into from Aug 21, 2020

Conversation

mcdado
Copy link
Contributor

@mcdado mcdado commented Aug 20, 2020

Questions Answers
Branch? develop
Description? Just fixing some comments
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? n/a

This change is Reviewable

@mcdado mcdado requested a review from a team as a code owner August 20, 2020 14:02
@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

Your pull request description seems to be incomplete or malformed:

  • Your pull request does not seem to fix any issue, you might consider creating one (see note below).

Would you mind completing it? This would help us understand how interesting your contribution is, thank you very much!

Note: it is a good practice to open an issue before submitting a Pull Request as it allows maintainers to verify that the bug is effectively due to a defect in the code (and that it hasn't already been fixed) and to discuss the improvement/feature suggestion before a single line of code is written. Additionally, it may lead the Core Product team to mark that issue as a priority, further attracting the maintainer's attention.

(note: this is an automated message, but answering it will reach a real human )

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Aug 20, 2020
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@NeOMakinG NeOMakinG added the QA ✔️ Status: check done, code approved label Aug 21, 2020
@NeOMakinG NeOMakinG merged commit 034ea8f into PrestaShop:develop Aug 21, 2020
@NeOMakinG
Copy link

Thanks @mcdado

@mcdado mcdado deleted the fix-tax-doc-comments branch August 21, 2020 14:15
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Sep 2, 2020
@Progi1984 Progi1984 added this to Done in PrestaShop 1.7.8.0 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants